Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(clients): endpoint level timeout part 2 [skip-bc] #4318

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

feat(clients): endpoint level timeout part 2 [skip-bc] #4318

wants to merge 21 commits into from

Conversation

Fluf22
Copy link
Contributor

@Fluf22 Fluf22 commented Jan 8, 2025 •
edited by jira bot
Loading

🧭 What and Why

🎟 JIRA Ticket: DI-3322 & DI-3327 & DI-3328 & DI-3329 & DI-3330 & DI-3331 & DI-3332 & DI-3333 & DI-3382

Changes included:

  • Swift
  • Kotlin
  • Java
  • Scala
  • C#
  • PHP
  • Go
  • Dart?

🧪 Test

@Fluf22 Fluf22 self-assigned this Jan 8, 2025
@algolia-bot
Copy link
Collaborator

algolia-bot commented Jan 8, 2025 •
edited
Loading

🪓 The generated code will be pushed at the end of the CI.

Action triggered by commit 5f3651929229e15549dfbd01a27fdf830f05ef23.

Please do not push any generated code to this pull request.

@Fluf22 Fluf22 force-pushed the fix/endpoint-level-timeouts branch 7 times, most recently from fae535d to 52dfa8f Compare January 9, 2025 16:18
@Fluf22 Fluf22 force-pushed the fix/endpoint-level-timeouts branch from 52dfa8f to 3fb27f1 Compare January 9, 2025 16:19
@Fluf22 Fluf22 force-pushed the fix/endpoint-level-timeouts branch from 3fb27f1 to 1da1e81 Compare January 9, 2025 17:08
@Fluf22 Fluf22 force-pushed the fix/endpoint-level-timeouts branch from 9e7e6a9 to e53bc13 Compare January 10, 2025 10:00
@Fluf22
Copy link
Contributor Author

Fluf22 commented Jan 10, 2025

After the next release, I will rebase this PR on main so the CI for Java 17 can pass

@Fluf22 Fluf22 marked this pull request as ready for review January 10, 2025 10:13
@Fluf22 Fluf22 requested a review from a team as a code owner January 10, 2025 10:13
@millotp
Copy link
Collaborator

millotp commented Jan 10, 2025

After the next release, I will rebase this PR on main so the CI for Java 17 can pass

Or you can add [skip-bc] at the end of the title

@Fluf22
Copy link
Contributor Author

Fluf22 commented Jan 10, 2025

Or you can add [skip-bc] at the end of the title

Yeah but it's not an urgent PR? I don't think it will be merged before next week, so let's wait?

millotp
millotp reviewed Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is huge !

templates/java/api.mustache Outdated Show resolved Hide resolved
clients/algoliasearch-client-csharp/algoliasearch/Http/RequestOptions.cs Outdated Show resolved Hide resolved
generators/src/main/java/com/algolia/codegen/lambda/ToSecondsLambda.java Show resolved Hide resolved
@millotp millotp changed the title feat(clients): endpoint level timeout part 2 feat(clients): endpoint level timeout part 2 [skip-bc] Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@millotp millotp millotp left review comments

@morganleroi morganleroi Awaiting requested review from morganleroi morganleroi is a code owner automatically assigned from algolia/api-clients-automation

@shortcuts shortcuts Awaiting requested review from shortcuts

At least 1 approving review is required to merge this pull request.

Assignees

@Fluf22 Fluf22

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Fluf22 @algolia-bot @millotp